save soil water stress factor and leaf water potential in outputs

EcoExtreML / STEMMUS_SCOPE

Integrated code of SCOPE and STEMMUS

https://EcoExtreML.github.io/STEMMUS_SCOPE

GNU General Public License v3.0

15 stars 6 forks source link

save soil water stress factor and leaf water potential in outputs #229

Closed Crystal-szj closed 5 months ago

Crystal-szj commented 6 months ago

Description

The soil water stress factor sfactorTot and leaf water potential psiLeafTot are saved in the output.mat.

We only save additional variables rather than change physical processes. Thus, no references are needed for this issue.

relates to https://github.com/EcoExtreML/STEMMUS_SCOPE_Processing/issues/102

Checklist

[x] Add a reference to related issues.
[x] @mentions of the person or team responsible for reviewing proposed changes.
[x] This pull request has a descriptive title.
[x] Code is written according to the guidelines.
[x] The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
[x] Documentation is available.
[x] Add changes to the changelog file under section Unreleased.
[x] Model runs successfully.
[x] Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

Crystal-szj commented 6 months ago

Hi @SarahAlidoost and @BSchilperoort, the soil water stress factor (sfactor) and leaf water potential (psiLeaf) are important indicators for drought effect, and should be saved into the output file for further analysis. Here, the two variables are passed from ebal.m to STEMMUS-SCOPE.m, and the time series are assigned to variables with 'Tot' suffix (i.e. sfactorTot, and psiLeafTot).

Let me know if there were more efficient way for that!

Crystal-szj commented 6 months ago

Thanks for your suggestions. The soil water stress and leaf water potential are saved in two structures as WaterStressFactor.soil and WaterPotential.leaf in the code, and are saved as binary files every time step. The reason for using structures instead of variables is because the recent coupling of plant hydraulics module to the current version will output plant water stress factor, as well as root and stem water potentials.

SarahAlidoost commented 6 months ago

Thanks for your suggestions. The soil water stress and leaf water potential are saved in two structures as WaterStressFactor.soil and WaterPotential.leaf in the code, and are saved as binary files every time step. The reason for using structures instead of variables is because the recent coupling of plant hydraulics module to the current version will output plant water stress factor, as well as root and stem water potentials.

Is your pull request ready again for review? I run the model in your branch. The output folder does not include the csv files of WaterStressFactor and WaterPotential. Can you please check it?

Crystal-szj commented 6 months ago

Thanks for your suggestions. The soil water stress and leaf water potential are saved in two structures as WaterStressFactor.soil and WaterPotential.leaf in the code, and are saved as binary files every time step. The reason for using structures instead of variables is because the recent coupling of plant hydraulics module to the current version will output plant water stress factor, as well as root and stem water potentials.

Is your pull request ready again for review? I run the model in your branch. The output folder does not include the csv files of WaterStressFactor and WaterPotential. Can you please check it?

Hi @SarahAlidoost, I have just checked the repo, and the model output on my side and found that the output file name are "waterPotential.csv" and "waterStressFactor.csv" (i.e. lowercase for 'water'), Could you help to check if the file were there? cheers!