Closed MostafaGomaa93 closed 5 months ago
@MostafaGomaa93 I noticed small differences in values of fluxes, soil moisture and soil temperature comparing branch main
with branch SSM_v.0.3.2
. I guess the differences are due to improvements like the new calculation of surface runoff, calculation of QVT mentioned in #230, .... Can you please summarize these sorts of improvements as some bullet items here. I can use them for the changelog file. Thanks
@MostafaGomaa93 I noticed small differences in values of fluxes, soil moisture and soil temperature comparing branch
main
with branchSSM_v.0.3.2
. I guess the differences are due to improvements like the new calculation of surface runoff, calculation of QVT mentioned in #230, .... Can you please summarize these sorts of improvements as some bullet items here. I can use them for the changelog file. Thanks@SarahAlidoost, I updated the explanation of the changes above. Is that okay now?
@MostafaGomaa93 I noticed small differences in values of fluxes, soil moisture and soil temperature comparing branch
main
with branchSSM_v.0.3.2
. I guess the differences are due to improvements like the new calculation of surface runoff, calculation of QVT mentioned in #230, .... Can you please summarize these sorts of improvements as some bullet items here. I can use them for the changelog file. Thanks@SarahAlidoost, I updated the explanation of the changes above. Is that okay now?
thanks, perfect :+1:
The code has been updated in the SSM_v.0.3.2 branch with the following:
Changes that work only if groundwater coupling is activated
New folder
+groundwater
, includes 3 functions: 1-readGroundwaterSettings
. This function includes the groundwater data inputs (e.g. groundwater head, groundwater temperature). 2-findPhreaticSurface
. This function finds the soil layer that includes the groundwater head using the soil matric potential (the first layer that has zero matric potential). 3-calculateGroundwaterRecharge
. This function calculates the groundwater recharge, which will be passed to MODFLOW through BMI.Update all functions in the
+soilmoisture
,+energy
,+dryair
folders to account for the location of the groundwater level. The main change after activating the groundwater coupling is that the soil profile is not fixed (default = 5 m) anymore and is changed per timestep based on the index of the bottom soil layerGroundwaterSettings.indxBotmLayer
(see for example a function from+soilmoisture
and a function from+energy
). TheGroundwaterSettings.indxBotmLayer
is calculated in thereadGroundwaterSettings
(lines 79-98).The root water uptake is modified (here and here) in the case of activating groundwater coupling (discussed in issue 231).
Changes that work with both cases (with and without groundwater coupling)
The surface runoff calculations are adjusted (here and here) as discussed in issue 232.
The bug in the QVT calculations is solved (see issue 230).
The error when activating the dry air calculations (switching the
Soilairefc
to be = 1 (here)) is solved, (see issue 227).