EcoExtreML / STEMMUS_SCOPE

Integrated code of SCOPE and STEMMUS
GNU General Public License v3.0
14 stars 6 forks source link

Adjust to let total soil thickness and max root depth be varied and not fixed #238

Closed MostafaGomaa93 closed 3 months ago

MostafaGomaa93 commented 3 months ago

Description

The indices of the first 4 layers (layers close to land surface) are from 51 to 55 (as long as the total soil thickness equals 5 m). However, if we change the total soil thickness (not 5 m), then the indices of the first 4 layers will not be from 51 to 55 anymore. So, a simple change in these 3 files (one, two, three) to get the proper indices of the first 4 layers. These changes are related to issue 237.

Checklist

MostafaGomaa93 commented 3 months ago

@MostafaGomaa93 please see my comment on the size of ModelSettings.DeltZ. Also, can you add one line to the changelog file explaining the changes? Thanks. After fixing the code, I will re-generate the exe file.

Could you show me how can I make changes in the changelog file and where is that file?

SarahAlidoost commented 3 months ago

@MostafaGomaa93 please see my comment on the size of ModelSettings.DeltZ. Also, can you add one line to the changelog file explaining the changes? Thanks. After fixing the code, I will re-generate the exe file.

Could you show me how can I make changes in the changelog file and where is that file?

The CHANGELOG.md is in the root of STEMMUS_SCOPE folder. In the file, under the section Unreleased/fixed, you can add one item for explaining changes in this pull request. Here example:

# Unreleased

**Changed:**

- ....

**Fixed:**

- .....
- The issue of defining te indices of first four layers.... is fixed in .... 
MostafaGomaa93 commented 3 months ago

@MostafaGomaa93 please see my comment on the size of ModelSettings.DeltZ. Also, can you add one line to the changelog file explaining the changes? Thanks. After fixing the code, I will re-generate the exe file.

Could you show me how can I make changes in the changelog file and where is that file?

The CHANGELOG.md is in the root of STEMMUS_SCOPE folder. In the file, under the section Unreleased/fixed, you can add one item for explaining changes in this pull request. Here example:

# Unreleased

**Changed:**

- ....

**Fixed:**

- .....
- The issue of defining te indices of first four layers.... is fixed in .... 

Thanks, I did it already