search

EcoExtreML / STEMMUS_SCOPE

Integrated code of SCOPE and STEMMUS
https://EcoExtreML.github.io/STEMMUS_SCOPE
GNU General Public License v3.0
15 stars 6 forks source link

Unused variables and equations in `groundwater` module #240

Closed SarahAlidoost closed 2 months ago

SarahAlidoost commented 4 months ago

@BSchilperoort and @MostafaGomaa93 There are some variables defined in scripts of +groundwater module that are not used by the rest of the model.

MostafaGomaa93 commented 4 months ago

Hi @SarahAlidoost. These unused variables are already part of the coupling methodology that we follow (https://doi.org/10.5194/hess-23-637-2019). However, as indicated in this line, the effect of these variables are minor, but I kept them for further testing in the future.

So, I would prefer we don't remove them. Maybe we can comment them in the meantime