Add model class - Githubissues

EcoExtreML / STEMMUS_SCOPE_Processing

Python modules and notebooks to process data and run STEMMUS-SCOPE model

https://pystemmusscope.readthedocs.io/en/latest/

Apache License 2.0

5 stars 1 forks source link

Add model class #21

Closed SarahAlidoost closed 2 years ago

SarahAlidoost commented 2 years ago

This PR:

[x] closes #18
[x] closes #22
[x] refactor forcing_io and soil_io and their tests
[x] add stemmus_scope class and its tests
[x] updates notebooks

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

98.5% Coverage
0.0% Duplication

SarahAlidoost commented 2 years ago

Looks great! This will make it a lot easier to run the model. I just had some small remarks for you to consider, but I will already mark it as approved.

thanks for reviewing. Please see my replies. Then I will merge it.