Closed BSchilperoort closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@BSchilperoort I finished the review, see also comments on the downloading_global_data.md
. The failed test is related to
FILE: ./docs/index.md
[✖] https://github.com/EcoExtreML/STEMMUS_SCOPE
[✓] installation_instructions.md
2 links checked.
ERROR: 1 dead links found!
[✖] https://github.com/EcoExtreML/STEMMUS_SCOPE → Status: [40]
In ./docs/index.md
file where:
<!-- markdown-link-check-disable-next-line -->
The model source code, executable file and utility files are available in the
[STEMMUS_SCOPE repository](https://github.com/EcoExtreML/STEMMUS_SCOPE).
The text is split into two lines and hence, themarkdown-link-check-disable-next-line
does not work.
the forcing files from the Plumber2 follow ALMA convention
Well, they kind-of do. From how I interpret the document, the "reference height" is supposed to be a dimension. The document (from 2002) does not contain a lot of information to actually definitively say how to structure the netCDF, how to name dimensions/coordinates, etc. Surface elevation isn't even mentioned.
Kudos, SonarCloud Quality Gate passed!
This PR adds support for selecting a latitude + longitude to run STEMMUS_SCOPE globally.