EcoExtreML / STEMMUS_SCOPE_Processing

Python modules and notebooks to process data and run STEMMUS-SCOPE model
https://pystemmusscope.readthedocs.io/en/latest/
Apache License 2.0
5 stars 1 forks source link

Add an example notebook to run the model with global data #93

Closed SarahAlidoost closed 9 months ago

SarahAlidoost commented 10 months ago

closes #79 relates #https://github.com/EcoExtreML/STEMMUS_SCOPE/pull/219

Broken links will be fixed after merging.

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

SarahAlidoost commented 9 months ago

I mostly have some comments on the naming. Otherwise things look fine.

Thanks, I fixed the text.

Will we want to add the (Docker) BMI way of running the model to the PyStemmusScope options? That would make the executable file and octave unnecessary (unless you want to develop the model).

In principle yes, but for now I would like to keep it separate for advanced users. The main users of pystemmusscope are users of CRIB who may not be familiar with docker and bmi.

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud