Add convert method to dataset class ETH canopy height

EcoExtreML / zampy

Tool for downloading Land Surface Model input data

https://zampy.readthedocs.io/

Apache License 2.0

1 stars 0 forks source link

Add convert method to dataset class ETH canopy height #5

Closed geek-yang closed 1 year ago

geek-yang commented 1 year ago

Add convert method to ETH canopy height, to convert this global dataset to follow the ALMA convention. This includes:

Add convert method to the data downloaded class
Add load method to the data downloaded class
Put the convention-compliant conversion code into a new converter.py script, for all datasets.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

geek-yang commented 1 year ago

To review this PR, please run the demo notebook and check the code. (Note: Simply for a testing purpose, I haven't added a full list of ALMA variables to json. If we agree on this structure, I will add all relevant variables then. perhaps in another PR.)

geek-yang commented 1 year ago

Hi @BSchilperoort , just address all your comments, here is brief summary of changes:

convert function returns dataset (the converted dataset will be kept in memory which is ready for other computations to be executed)
support dask lazy loading
update ALMA json
rely on pint_dask for unit conversion (which is very elegant)

geek-yang commented 1 year ago

Hi @BSchilperoort, many thanks for the review and the nice comments! I address all your comments and please check the code and run the notebook again.