Open raoulKalkman opened 4 months ago
In secc/controller/interface.py
secc/controller/interface.py
I found some inconsistencies while writing my own implementation, they are as follows:
get_dc_charge_parameters_{v2|dinspec| }
get_dc_charge_params_v20
get_dc_charge_loop_params_v20
get_evse_present_voltage
get_evse_present_current
UnitSymbol
is_evse_current_limit_achieved
is_evse_voltage_limit_achieved
get_dc_charge_parameters_dinspec
get_dc_charge_parameters
Thank you for reading
In
secc/controller/interface.py
I found some inconsistencies while writing my own implementation, they are as follows:
get_dc_charge_parameters_{v2|dinspec| }
andget_dc_charge_params_v20
,get_dc_charge_loop_params_v20
follow different abbreviation methodsget_evse_present_voltage
andget_evse_present_current
the unit doesn't use theUnitSymbol
classis_evse_current_limit_achieved
andis_evse_voltage_limit_achieved
don't have their type hinting set to boolget_dc_charge_parameters_dinspec
andget_dc_charge_parameters
both say they're only relevant for -2Thank you for reading