EcoJulia / NeutralLandscapes.jl

Generation of neutral landscapes in Julia.
https://ecojulia.github.io/NeutralLandscapes.jl/dev/
MIT License
16 stars 2 forks source link

nearest neighbor :queen no longer goes out of bounds #54

Closed gottacatchenall closed 3 years ago

gottacatchenall commented 3 years ago

What the pull request does
fixes the bug in #53

Type of change
Please indicate the relevant option(s)

Checklist

codecov-io commented 3 years ago

Codecov Report

Merging #54 (987d420) into main (4aafae2) will decrease coverage by 4.03%. The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   88.85%   84.81%   -4.04%     
==========================================
  Files          14       14              
  Lines         296      303       +7     
==========================================
- Hits          263      257       -6     
- Misses         33       46      +13     
Flag Coverage Δ
unittests 84.81% <22.22%> (-4.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/classify.jl 46.57% <22.22%> (-14.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4aafae2...987d420. Read the comment docs.

tpoisot commented 3 years ago

@gottacatchenall I've updated the release number, you can merge when all the tests pass - do you know how to tag the new release using the bot?

gottacatchenall commented 3 years ago

do i just make a new release? doesn't look like i can run the tagbot workflow @tpoisot