search

EcoJulia / Phylo.jl

Simple phylogenetic trees in Julia to work with Diversity.jl - https://github.com/EcoJulia/Diversity.jl
BSD 2-Clause "Simplified" License
34 stars 13 forks source link

Really fix dependencies #32

Closed mkborregaard closed 4 years ago

mkborregaard commented 4 years ago

This reverts commit f361f786a0c048c9ab9be41ab7b42a822eca8e41.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-2.06%) to 56.879% when pulling 0a26a18ca0920d5cf992b7e26709bbeafa9117a2 on mkborregaard:mkb/deps into f5a09eaaba91b6c28129e2b7b3c113e98b9265bb on richardreeve:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 58.935% when pulling df2bd6fc9c02de00a84f605b3c84a9a337ab3132 on mkborregaard:mkb/deps into f5a09eaaba91b6c28129e2b7b3c113e98b9265bb on richardreeve:master.

mkborregaard commented 4 years ago

Hello @richardreeve the fix on PenaltyFunctions appears to have fixed the issues - I've removed the two unnecessary deps again and widened the compat on RecipesBase. This is ready to merge.

richardreeve commented 4 years ago

Thanks so much for this @mkborregaard. I’m slightly relieved you didn’t find it trivial after I was tearing my hair out over it, but mostly just pleased it’s fixed! Why anyone thinks it’s good practice to have travis see different dependencies that people’s machines is a mystery that may never get resolved!

mkborregaard commented 4 years ago

I think other people installing your package with add would have the same problem

richardreeve commented 4 years ago

Okay. I didn’t get the same result when I freed Phylo to get to the default package on General, but I guess I couldn’t free Diversity because I couldn’t get it to pass travis and so release a version.

mkborregaard commented 4 years ago

it's a bit weird