EcoJulia / RasterDataSources.jl

Easily download and use raster data sets in Julia
MIT License
21 stars 10 forks source link

bugfix, refactor and standardise earthenv #30

Closed rafaqz closed 3 years ago

rafaqz commented 3 years ago

EarthEnv downloads were not all working, this PR fixes all downloads.

The filenames and path were also quite custom, when other sources just use the original name of the file. As people don't really need to look at the names much this is easier and more consistent than thinking of new file names. In contrast, the folder was also using the url path instead of LandCover or HabitatHeterogeneity as other sources do (this may not be totally consistent yet).

discover was also the only keyword not related to spatial/temporal extent or grain. It's specifying the model used to generate the data, not a specific subset or resolution of the same data, so this is something for the source type.

This is a breaking change.

Closes #27

codecov-commenter commented 3 years ago

Codecov Report

Merging #30 (ebe3bc5) into master (f3b3c15) will increase coverage by 0.63%. The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   82.32%   82.95%   +0.63%     
==========================================
  Files          12       12              
  Lines         215      223       +8     
==========================================
+ Hits          177      185       +8     
  Misses         38       38              
Impacted Files Coverage Δ
src/earthenv/shared.jl 100.00% <ø> (ø)
src/earthenv/habitatheterogeneity.jl 92.85% <86.66%> (-7.15%) :arrow_down:
src/earthenv/landcover.jl 100.00% <100.00%> (+6.66%) :arrow_up:
src/worldclim/weather.jl 20.00% <0.00%> (+0.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3b3c15...ebe3bc5. Read the comment docs.