EcoJulia / RasterDataSources.jl

Easily download and use raster data sets in Julia
MIT License
21 stars 10 forks source link

add getraster_keywords trait #57

Closed rafaqz closed 1 year ago

rafaqz commented 1 year ago

@asinghvi17 this makes the keywords for each source explicit and extensible.

I'm not totally sure it makes sense, just having an object could be better. But it will work for now.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.24 :tada:

Comparison is base (1756e72) 71.97% compared to head (9a3752e) 72.22%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #57 +/- ## ========================================== + Coverage 71.97% 72.22% +0.24% ========================================== Files 19 19 Lines 728 738 +10 ========================================== + Hits 524 533 +9 - Misses 204 205 +1 ``` | [Impacted Files](https://codecov.io/gh/EcoJulia/RasterDataSources.jl/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia) | Coverage Δ | | |---|---|---| | [src/alwb/alwb.jl](https://codecov.io/gh/EcoJulia/RasterDataSources.jl/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia#diff-c3JjL2Fsd2IvYWx3Yi5qbA==) | `0.00% <0.00%> (ø)` | | | [src/srtm/srtm.jl](https://codecov.io/gh/EcoJulia/RasterDataSources.jl/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia#diff-c3JjL3NydG0vc3J0bS5qbA==) | `0.00% <0.00%> (ø)` | | | [src/awap/awap.jl](https://codecov.io/gh/EcoJulia/RasterDataSources.jl/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia#diff-c3JjL2F3YXAvYXdhcC5qbA==) | `80.64% <100.00%> (+0.64%)` | :arrow_up: | | [src/chelsa/future.jl](https://codecov.io/gh/EcoJulia/RasterDataSources.jl/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia#diff-c3JjL2NoZWxzYS9mdXR1cmUuamw=) | `62.85% <100.00%> (+0.53%)` | :arrow_up: | | [src/earthenv/habitatheterogeneity.jl](https://codecov.io/gh/EcoJulia/RasterDataSources.jl/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia#diff-c3JjL2VhcnRoZW52L2hhYml0YXRoZXRlcm9nZW5laXR5Lmps) | `94.44% <100.00%> (+0.15%)` | :arrow_up: | | [src/modis/shared.jl](https://codecov.io/gh/EcoJulia/RasterDataSources.jl/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia#diff-c3JjL21vZGlzL3NoYXJlZC5qbA==) | `92.85% <100.00%> (+0.08%)` | :arrow_up: | | [src/shared.jl](https://codecov.io/gh/EcoJulia/RasterDataSources.jl/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia#diff-c3JjL3NoYXJlZC5qbA==) | `65.00% <100.00%> (+0.89%)` | :arrow_up: | | [src/worldclim/bioclim.jl](https://codecov.io/gh/EcoJulia/RasterDataSources.jl/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia#diff-c3JjL3dvcmxkY2xpbS9iaW9jbGltLmps) | `100.00% <100.00%> (ø)` | | | [src/worldclim/climate.jl](https://codecov.io/gh/EcoJulia/RasterDataSources.jl/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia#diff-c3JjL3dvcmxkY2xpbS9jbGltYXRlLmps) | `100.00% <100.00%> (ø)` | | | [src/worldclim/weather.jl](https://codecov.io/gh/EcoJulia/RasterDataSources.jl/pull/57?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia#diff-c3JjL3dvcmxkY2xpbS93ZWF0aGVyLmps) | `17.64% <100.00%> (+2.94%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=EcoJulia)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

asinghvi17 commented 1 year ago

On first glance, it looks like it'll work for now, though I would like to build in object support at some stage. Still, this should make things a lot more configurable!

rafaqz commented 1 year ago

Yeah, lets just make them all objects at some stage. But it will be hugely breaking, there will be documentation and scripts to update everywhere.

This works for now. I'll PR Rasters.jl to use this too.