search

EcoJulia / SpatialEcology.jl

Julia framework for spatial ecology - data types and utilities
Other
58 stars 7 forks source link

CompatHelper: bump compat for "DataFrames" to "0.21" #54

Closed github-actions[bot] closed 4 years ago

github-actions[bot] commented 4 years ago

This pull request changes the compat entry for the DataFrames package from 0.20 to 0.20, 0.21.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

kescobo commented 4 years ago

@mkborregaard May also need to deal with some other upper bounds for eg CategoricalArrays. Also - what's DataFramesMeta being used for? Might be worth trying to drop that dep with DataFrames 0.21. Or does all the DataFrames stuff become moot if I actually finish #37 ?

mkborregaard commented 4 years ago

Yeah, I'll probably lowerbound categoricalarrays and dataframes and drop backwards compatibility. Part of the game when depending on pre-1.0 packages.

DataFramesMeta is used because I define a new method for @with that allows accessing the columns in the traits DataFrame and such in Assemblage objects by symbol (I also have '@traitsand@sites` macros.

The Assemblage objects use DataFrames internally, but I guess we could make the objects parametric on the specific table object if we wanted to drop DataFrames?

I think your #37 is intended to use the Tables interface on ComMatrix objects, not to replace DataFrames, right?

kescobo commented 4 years ago

I think your #37 is intended to use the Tables interface on ComMatrix objects, not to replace DataFrames, right?

Yes, that's the intention, but ComMatrices are basically the only thing from this package that I'm using, so I didn't know where were other uses :-)

mkborregaard commented 4 years ago

Assemblages are just ComMatrices with spatial data, and traits for each species/OTU :-) They have the exact same API just hold more data