The main impetus of this PR is to bump compat with DataFrames 0.21, which I thought would be quicker than finishing #37. I also changed julia compat to just "1.2" (because of semver this is identical to what you had before), fixed a deprecation warning from CSV.read in the tests, and added 1.5 to travis. This closes #54 as well.
There was also a failing test in Analysis_tests.jl related to the addtraits!() function, due to the fact that names(df) now returns Strings (see here). I went looking and tried to fix other instances like this, but not sure I found them all. In any case, tests pass locally for these changes.
mkborregaard
commented
4 years ago
The main impetus of this PR is to bump compat with DataFrames 0.21, which I thought would be quicker than finishing #37. I also changed julia compat to just "1.2" (because of semver this is identical to what you had before), fixed a deprecation warning from CSV.read in the tests, and added 1.5 to travis. This closes #54 as well.
There was also a failing test in
Analysis_tests.jlrelated to theaddtraits!()function, due to the fact thatnames(df)now returnsStrings (see here). I went looking and tried to fix other instances like this, but not sure I found them all. In any case, tests pass locally for these changes.