Ecodev / fab-speed-dial

Angular Material FAB speed dial
https://ecodev.github.io/fab-speed-dial
MIT License
89 stars 19 forks source link

Why this package is downloading Chromium?? #23

Closed ozzpy closed 4 years ago

ozzpy commented 5 years ago

$npm install ecodev/fab-speed-dial

puppeteer@1.20.0 install /home/webmaster/Angular/fab-speed-dial/node_modules/puppeteer node install.js

Downloading Chromium r686378 - 114 Mb [====================] 100% 0.0s Chromium downloaded to /home/webmaster/Angular/fab-speed-dial/node_modules/puppeteer/.local-chromium/linux-686378

PowerKiKi commented 4 years ago

Installing this package for production does not install puppeteer, as shown here:

$ mkdir empty-foler
$ cd empty-foler/
$ yarn add @ecodev/fab-speed-dial
yarn add v1.19.1
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @ecodev/fab-speed-dial@4.0.0" has unmet peer dependency "@angular/common@^8.2.0".
warning " > @ecodev/fab-speed-dial@4.0.0" has unmet peer dependency "@angular/core@^8.2.0".
warning " > @ecodev/fab-speed-dial@4.0.0" has unmet peer dependency "@angular/material@^8.1.2".
warning " > @ecodev/fab-speed-dial@4.0.0" has unmet peer dependency "rxjs@^6.5.2".
[4/4] Building fresh packages...

success Saved lockfile.
success Saved 2 new dependencies.
info Direct dependencies
└─ @ecodev/fab-speed-dial@4.0.0
info All dependencies
├─ @ecodev/fab-speed-dial@4.0.0
└─ tslib@1.10.0
Done in 0.83s.
$ yarn list
yarn list v1.19.1
warning package.json: No license field
warning No license field
├─ @ecodev/fab-speed-dial@4.0.0
│  └─ tslib@^1.9.0
└─ tslib@1.10.0
Done in 0.09s.

It will only be installed when you develop this package.

Try yarn why puppeteer to know where it is coming from.

ozzpy commented 4 years ago

with npm,l it install chromium!

PowerKiKi commented 4 years ago

No, it doesn't. Note there are only two folders installed at the very end, nothing else:

$ mkdir empty-foler
$ cd empty-foler/
$ npm i @ecodev/fab-speed-dial
npm WARN saveError ENOENT: no such file or directory, open '/tmp/empty-foler/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/tmp/empty-foler/package.json'
npm WARN @ecodev/fab-speed-dial@4.0.0 requires a peer of @angular/common@^8.2.0 but none is installed. You must install peer dependencies yourself.
npm WARN @ecodev/fab-speed-dial@4.0.0 requires a peer of @angular/core@^8.2.0 but none is installed. You must install peer dependencies yourself.
npm WARN @ecodev/fab-speed-dial@4.0.0 requires a peer of @angular/material@^8.1.2 but none is installed. You must install peer dependencies yourself.
npm WARN @ecodev/fab-speed-dial@4.0.0 requires a peer of rxjs@^6.5.2 but none is installed. You must install peer dependencies yourself.
npm WARN empty-foler No description
npm WARN empty-foler No repository field.
npm WARN empty-foler No README data
npm WARN empty-foler No license field.

+ @ecodev/fab-speed-dial@4.0.0
added 2 packages from 1 contributor and audited 2 packages in 3.162s
found 0 vulnerabilities

$ ls node_modules/
@ecodev  tslib