search

Ecodev / newsletter

TYPO3 extension to send newsletter
https://extensions.typo3.org/extension/newsletter/
25 stars 26 forks source link

Fix for #123 #124

Closed cundd closed 8 years ago

cundd commented 8 years ago

I also made some smaller changes in the Email controller

PowerKiKi commented 8 years ago

Thanks for your PR. I took the liberty to cherry-pick each commits and make some slight modifications. Mostly for style code, but also reverting the introduction of a bug and simplifying tests. Btw thanks for taking time to add tests.

Next time it would be best if you could avoid mixing style changes and bugfixes in the same commit. Also creating a PR for each topic, rather than a PR from your master branch accumulating all commits you push, would simplify the review process.

Anyway, it's now released as 3.0.2.

PS: I wrote my remarks in the code for information, but you don't need to do anything about it.