Ecodev / newsletter

TYPO3 extension to send newsletter
https://extensions.typo3.org/extension/newsletter/
25 stars 26 forks source link

remove t3skin relations #156

Closed conpassione closed 6 years ago

conpassione commented 6 years ago

As stated in https://docs.typo3.org/typo3cms/extensions/core/7.6/Changelog/7.0/Breaking-61471-t3skinCssFilesMovedToLess.html all relations to t3skin should be removed.

For TYPO3 8LTS you schould change Line 48 in Classes/ViewHelpers/Be/ModuleContainerViewHelper.php

old: $this->pageRenderer->addCssFile('sysext/t3skin/extjs/xtheme-t3skin.css'); new: $this->pageRenderer->addCssFile('sysext/core/Resources/Public/ExtJs/xtheme-t3skin.css');

Please be aware that this is working only for TYPO3 8LTS, in TYPO3 9 ExtJs and t3skin will be removed!

Best Regards, Renzo

conpassione commented 6 years ago

Uups, this is the case only for the actual TER Version. In the actual Version 3.3.1 this is allready solved. Thanks! Best Regards, Renzo

PowerKiKi commented 6 years ago

Thanks for the report. I always recommend installing from packagist, instead of TER, because it is easier to maintain and more reliable in my experience.

But I just checked Newsletter 3.3.1 as downloaded from TER and confirmed that it is also fixed and correctly contains the following lines:

// From TYPO3 8.6.0 onward t3skin is located in core (see: https://forge.typo3.org/issues/79259).
if (version_compare(TYPO3_version, '8.6.0', '>=')) {
    $this->pageRenderer->addCssFile('sysext/core/Resources/Public/ExtJs/xtheme-t3skin.css');
} else {
    // Anything before 8.6.0 must still use the old t3skin EXT path.
    $this->pageRenderer->addCssFile('sysext/t3skin/extjs/xtheme-t3skin.css');
}
conpassione commented 6 years ago

Hello yes it is fixed in the TER Version. I downloaded a TER Version, investigated the problem and wrote the issue. But in the meantime you pushed a newer Version to TER :-) So, everything is good! Thanks for this amazing EXT!