search

Ecodev / newsletter

TYPO3 extension to send newsletter
https://extensions.typo3.org/extension/newsletter/
25 stars 26 forks source link

[TASK] Require separate TYPO3 packages #158

Closed mbrodala closed 5 years ago

mbrodala commented 6 years ago

This is considered good practice and allows for installing only the really necessary parts of TYPO3. Also starting with TYPO3v9 it is impossible to install "typo3/cms".

There is no "typo3/cms-lang" package anymore in TYPO3v9. This fact alone makes the currently declared full support of TYPO3v9 questionable.

PowerKiKi commented 6 years ago

As you may have seen there we don't test, nor even develop, with v9:

https://github.com/Ecodev/newsletter/blob/2b575eff2d78147c7fed0a7c36f33b49522118ea/.travis.yml#L17-L29

I guess the declaration in composer.json was a bit over-ambitious (to allow other users to try to install it and figure out if it works at all). But realistically, development for v9 will not happen at least before the LTS, and most likely even months later, because we don't have the resources to do anything earlier.

Do you have documentation about the removal of typo3/cms-lang and possible migration path ?

mbrodala commented 6 years ago

In that case the compatibility with TYPO3v9 should probably be removed again until it is properly tested. Also typo3/cms-lang should then probably be removed to ensure cross-version compatibility.

As for the LanguageService please see the core changelog.

mbrodala commented 5 years ago

@PowerKiKi can you have a look at this?

PowerKiKi commented 5 years ago

Thank you for pinging me.

I took a a few minutes to plan a v4 which would only support a single LTS of TYPO3 (because of increased complexity introduced by core). So for now it would be TYPO3 9. This would allow to clean up our code from all compatibility hacks and be clearer in supported versions.

Unfortunately I still cannot afford much time on this project, and even though I'll try to spend a bit more time on it in the coming weeks, I cannot give you any ETA for that v4.

mbrodala commented 5 years ago

I can fully understand. Would it be possible to add this change and make a new 3.x release? Right now this package cannot be installed if only typo3/cms-* packages are required.

PowerKiKi commented 5 years ago

Released as 3.3.2

mbrodala commented 5 years ago

Thanks a lot! :-)