Ecodev / newsletter

TYPO3 extension to send newsletter
https://extensions.typo3.org/extension/newsletter/
25 stars 26 forks source link

Migrate away from Mcrypt #165

Closed cyMarvin closed 5 years ago

cyMarvin commented 6 years ago

When saving a bounce account with PHP 7.2 you get the following error message: bildschirmfoto 2018-08-14 um 10 52 31

The function mcrypt_create_iv used in Ecodev\Newsletter\Tools::encrypt($str) was removed. Please see: http://php.net/manual/de/function.mcrypt-create-iv.php

Also mcrypt_encrypt will be removed soon.

PowerKiKi commented 6 years ago

This is unfortunately correct, we need to move from Mcrypt to something else (openssl?), maybe even nothing at all and go back to sorting plain passwords...

Any help on the matter would be very appreciated, I don't have availability in the foreseeable future.

cyMarvin commented 6 years ago

Please don’t save it plain. ^^ It seems to be only the encrypt and decrypt methods. I’ll implement an openssl alternative with a PHP_VERSION check so it will be compatible with 7.2 and older versions. Pull request coming soon. ;)