search

EcohydrologyTeam / CEQUALW2geomTools

Code Development for CE-QUAL-W2 Geometry Tools
0 stars 0 forks source link

New feature: merge capabilities of the "CE-QUAL-W2_Bathymetry" QGIS plug-in into this repo #5

Open jrutyna opened 1 year ago

jrutyna commented 1 year ago

Source code for the "CE-QUAL-W2_Bathymetry" repo is here: https://github.com/WQDSS/qgis-cequalw2-bath/tree/master/create_bathymetry

@aufdenkampe suggested the following methods in his 8/22/2023 email regarding this issue (@jrutyna is in favor of the second method):

The open-source copyright license is a little buried, but the init and main module file have a header saying that it is under the GPLv2 license, which is “copy-left”, where any derivatives need to also be GPLv2. I don’t think this will be a problem, and mostly applies if we take option 1 below.

There are two ways to incorporate this code that comes to mind.

  1. Copy/paste code and/or files as we want into our code a. This requires that we provide attribution in the relevant code block and release our code a GPLv2 license.
    b. This would make it much more difficult to benefit from any updates the original author might make on the codebase. It looks like there has been no work done since the original 3-month effort in 2019, so this doesn’t appear to be a likely drawback.

  2. We use this repo as a dependency of our repo, calling it’s functions and classes in our code. a. If we need to modify their code, we can fork the repo, and include our fork as a dependency. The fork will also be GPLv2. b. This does not require any specific licensing for our main repo, nor any acknowledgement other than listing their repo as a dependency.

aufdenkampe commented 1 year ago

@jrutyna and @irishrose0312, yesterday I moved ahead with my option 2 by forking the qgis-cequalw2-bath repo to this organization, now at https://github.com/EcohydrologyTeam/qgis-cequalw2-bath.

This fork allows us to make changes if necessary to it's source code, while still showing an explicit connection to the "upstream" original repository maintained by the original developer.

This fork allows us to easily pull and developments by the original developer, or if our modifications are worth sharing back, issue a pull request back to the upstream repository.