search

EcohydrologyTeam / ClearWater-modules

A collection of water quality and vegetation process simulation modules designed to couple with water transport models.
MIT License
5 stars 1 forks source link

TwaterC in Multiple Modules #29

Open kewalak opened 1 year ago

kewalak commented 1 year ago

TwaterC is used in multiple modules (tsm, nsm1, etc). Need to make sure it can be shared across modules.

Also need to make surface_area and Volume (from tsm) shared to calculated depth used in many nsm1 modules.

imscw95 commented 1 year ago

I am thinking of the 'state variables' as any variable that gets re-computed by the CWR engine and passed back to the modules. That would go for surface_area, volume, TwaterC, and all other constituents that are transported, and hydraulic properties that are needed in the modules (e.g. velocity). These could all live in one file in our modules that gets imported to each processes file, and gets updated by the relevant process. That would mean our state_variable file would need to import each module_processes file in order to update the values. To me this seems like a viable option.

xaviernogueira commented 1 year ago

@kewalak no worries if you don't have the answer now, but is it shared as in you would run TSM and NSM at the same time, or is it just that NSM also have a state variable TwaterC?

kewalak commented 1 year ago

@xaviernogueira NSM just uses the variable TwaterC. I am assuming they could run at the same time and NSM would calculate based on the current timestep not the new TwaterC value calculated in TSM (?)