search

EcohydrologyTeam / ClearWater-modules

A collection of water quality and vegetation process simulation modules designed to couple with water transport models.
MIT License
5 stars 1 forks source link

Ijm alk pom #47

Closed imscw95 closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #47 (7d24a6e) into main (2c240d7) will decrease coverage by 0.04%. Report is 1 commits behind head on main. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   35.47%   35.44%   -0.04%     
==========================================
  Files          33       33              
  Lines        1122     1123       +1     
==========================================
  Hits          398      398              
- Misses        724      725       +1
Files Coverage Δ
src/clearwater_modules/nsm1/state_variables.py 0.00% <0.00%> (ø)
imscw95 commented 1 year ago

Not sure what the failed codecov means.

xaviernogueira commented 1 year ago

Not sure what the failed codecov means.

Don't worry about it now, it is telling you that the code you added is not tested in the automated pytest suite. I will make an Issue reflecting that and we can loop back to it once the whole module is closer to finalized.

Also, going to review your PR now.