search

EcohydrologyTeam / ClearWater-modules

A collection of water quality and vegetation process simulation modules designed to couple with water transport models.
MIT License
5 stars 1 forks source link

Add updateable static variables to TSM #55

Closed sjordan29 closed 11 months ago

sjordan29 commented 1 year ago

Hi @xaviernogueira, I couldn't get the updateable_static_variables to work with the EnergyBudget model so I made this update and added a test to the TSM test suite (#54 )

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4459156) 38.41% compared to head (f0960be) 38.41%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #55 +/- ## ======================================= Coverage 38.41% 38.41% ======================================= Files 33 33 Lines 1161 1161 ======================================= Hits 446 446 Misses 715 715 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aufdenkampe commented 11 months ago

@xaviernogueira, can you review this PR and merge it? @sjordan29's coupling to riverine depend on these fixes.

xaviernogueira commented 11 months ago

Sorry this PR slipped thru the cracks, I already implemented a fix with PR #56 . Apologies for the redundancy!