GSM - rate coefficients for different orders

[sjordan29]

    @sjordan29 Just a heads up, we need to change the formulation of this module to match the fortran's correctly. I have attached an screen shot from an email I sent about the inaccuracy in the python. The fortran is correct. I plan to work on this soon, but am busy with some other tasks at the moment. Will it affect your ability to vectorize the code? 

Originally posted by @imscw95 in https://github.com/EnvironmentalSystems/ClearWater-modules-python/issues/4#issuecomment-1352228261

[sjordan29]

@imscw95, track your progress resolving this issue here (whenever you get to it!). You can tag commits with this issue as well so we can see the work that went into resolving the issue by adding a #7 to the commit description. Feel free to close it out whenever you have it fixed!

[imscw95]

@sjordan29 I am converting GSM to the class based structure, where we set defaults for some of the parameters in the module, and then pass a dictionary with constant_changes. This will sub in for the function arguments, where it appears you've done some of the array-type set up. I feel like this is a place where we'd need to communicate? The image shows where I stopped off.

[sjordan29]

@imscw95 -- feel free to replace the function arguments with the dictionary! All I've added is type hinting, which doesn't really impact the code itself. Totally fine with me if you delete what I've worked on.

Since you're actively working on GSM, I think you should go ahead with getting this set up how you've worked on the other modules. Whenever you're done, I can revisit vectorizing the calculations.

[imscw95]

Ok sounds like a plan.

[xaviernogueira]

@imscw95 is this done or outdated? If so let's close it out.

[imscw95]

Outdated.