Closed sjordan29 closed 2 weeks ago
Looks like the tests that were failing were remnants of #87, which we discussed and were OK with failing.
I added the @pytest.mark.xfail(reason="Known issue with kbod 20 test TBA.")
decorator to these. This should ensure the pipeline passes but still flags the failing tests. Can @imscw95 or @aufdenkampe open an issue detailing the status of the test that's failing?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.13%. Comparing base (
ca28ae8
) to head (eaf0b58
). Report is 37 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'll be out of office until 9/12. @imscw95, if you get a chance to review and all looks OK - feel free to merge to main. Otherwise, we can resolve when I return. Thanks!
Addressing #79 with a quick fix. This adds a
dt
variable to TSM, with a default at 1 day to be consistent with NSM. When we merge this PR, we should open an issue to formalize time handling (potentially using xarray simlab).dt
parameter at 1/86400 days (1 second) and we get the correct outputdt
.