EcohydrologyTeam / ClearWater-modules

A collection of water quality and vegetation process simulation modules designed to couple with water transport models.
MIT License
5 stars 0 forks source link

Add `dt` to TSM #89

Closed sjordan29 closed 2 weeks ago

sjordan29 commented 1 month ago

Addressing #79 with a quick fix. This adds a dt variable to TSM, with a default at 1 day to be consistent with NSM. When we merge this PR, we should open an issue to formalize time handling (potentially using xarray simlab).

sjordan29 commented 1 month ago

Looks like the tests that were failing were remnants of #87, which we discussed and were OK with failing.

I added the @pytest.mark.xfail(reason="Known issue with kbod 20 test TBA.") decorator to these. This should ensure the pipeline passes but still flags the failing tests. Can @imscw95 or @aufdenkampe open an issue detailing the status of the test that's failing?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.13%. Comparing base (ca28ae8) to head (eaf0b58). Report is 37 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #89 +/- ## ========================================== + Coverage 80.62% 89.13% +8.50% ========================================== Files 27 25 -2 Lines 1843 1712 -131 ========================================== + Hits 1486 1526 +40 + Misses 357 186 -171 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sjordan29 commented 1 month ago

I'll be out of office until 9/12. @imscw95, if you get a chance to review and all looks OK - feel free to merge to main. Otherwise, we can resolve when I return. Thanks!