EcohydrologyTeam / ClearWater-riverine

A 2D water quality transporter model to calculate conservative advection and diffusion of constituents from an unstructured grid of flows
MIT License
6 stars 0 forks source link

Additional updates to Demo notebooks #64

Closed aufdenkampe closed 4 months ago

aufdenkampe commented 4 months ago

@sjordan29, I'm getting a param.tap_plot error under Panel Interactive Timeseries section, when running what is now cell 33. Note that I split a number of cells up from your original to better isolate the error.

Also, this is the first time I got the notebook to run that far, due to issues with my environment.

It's possible that I'm using a newer environment than you, so it might be useful for you to confirm that it works in your current environment then update your environment to the latest possible with:

conda env update -f environment.yml --solver=libmamba --prune
sjordan29 commented 4 months ago

@aufdenkampe I updated the environment to include param. I updated the environment on my end and was able to run through the entire notebook. I also added a few updates to document the dynamic viz. Let me know if you're still running into trouble.

aufdenkampe commented 4 months ago

@sjordan29, that fixed it. Thank you! Thanks also for confirming that it worked with a fully updated conda environment.

I'll merge this PR, then you can issue the release!

aufdenkampe commented 4 months ago

@sjordan29, let's title the release something like "Coupling demo with ClearWater-modules TSM"