EcologyR / BlueCarbon

Estimation of organic carbon stocks and sequestration rates from soil/sediment cores from blue carbon ecosystems
https://ecologyr.github.io/BlueCarbon/
Other
2 stars 0 forks source link

estimate_h #20

Closed NPJuncal closed 1 year ago

NPJuncal commented 1 year ago

especificar nombres para que el ususario pueda cambiarlos

by default los usados en estimate_stock

NPJuncal commented 1 year ago

Done, testear y documentar

NPJuncal commented 1 year ago

check that the samples of each core are provided in order

NPJuncal commented 1 year ago

@Pakillo @Julenasti In estimate_h there are two small functions defined withing the function, shoud we take them out, like in the other main functions?

Julenasti commented 1 year ago

Hi Nerea, yes I'd follow the same approach as the others and take them out of the main function. I think it's easier to understand (e.g. https://github.com/EcologyR/BlueCarbon/blob/master/R/estimate_oc.R) This is looking very good!

NPJuncal commented 1 year ago

Function working and ready