search

EconForge / Dolo.jl

Economic modeling in Julia
Other
58 stars 29 forks source link

Error: Not triangular system in solution_order #84

Open AnasZa opened 7 years ago

AnasZa commented 7 years ago

This error could be more explicit for the sake of "user-friendliness".

Remark: The error : Not triangular system in solution_order means a problem in the section of a steady state calibration. First thing to check is whether you provided the steady state values for all the variable and defined all the parameters.

albop commented 7 years ago

That's a fair remark. Pr welcome ;-)

On Thu, 6 Jul 2017, 16:45 Aaz, notifications@github.com wrote:

This error could be more explicit for the sake of "user-friendliness".

Remark: The error : Not triangular system in solution_order means a problem in the section of a steady state calibration. First thing to check is whether you provided the steady state values for all the variable and defined all the parameters.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/EconForge/Dolo.jl/issues/84, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ5KVELbPHPvAPUE6whtahE-1M_EgPBks5sLQEpgaJpZM4OP01H .

AnasZa commented 7 years ago

I checked, and I can't correct this one through Dolo (not possible to creat an "if" condition). So somebody (@albop , @sglyon ) shall go Doland.scr.util.jl line 108 and edit it to something like:

!isempty(to_solve) && error("Not triangular system. Check whether the values provided in the calibration section solve the model. ")

AnasZa commented 7 years ago

Another question: How many new error messages worth a PR?

albop commented 7 years ago

the answer is blowin in the wind...

(more seriously: PR don't consume trees or any finite natural resources so you can do as many as you like. See https://github.com/EconForge/Dolo.jl/pull/80 for example.)