search

EconForge / interpolation.py

BSD 2-Clause "Simplified" License
123 stars 35 forks source link

TEST: nonempty result #113

Closed albop closed 3 months ago

albop commented 4 months ago

As proposed by @kp992, check that multilinear call returns non-None result

mmcky commented 3 months ago

@albop is this PR needed before release? I could use main branch version if release is held up.

albop commented 3 months ago

Well, so far this PR is only the test. Which doesn't pass on the main branch. I guess the solution is there though, in the other thread

On 20/03/2024 23:22, Matt McKay @.***> wrote:

@albop https://github.com/albop is this PR needed before release? I could use |main| branch version if release is held up.

— Reply to this email directly, view it on GitHub https://github.com/EconForge/interpolation.py/pull/113#issuecomment-2010750714, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACDSKOAF7ZBQJ5RFGKM76LYZIDY3AVCNFSM6AAAAABE3UOSJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJQG42TANZRGQ. You are receiving this because you were mentioned.Message ID: @.***>

albop commented 3 months ago

@mmcky : now main should be working, and nothing is holding the release. Save one little point: there is a bug in numba that has been fixed only in the last release, which in certain cases affects interpolation routines (if you do repeated calls while alternating number of dimensions). Which would be a good reason to bump the numba version. Unless you have some version constraint of yours ?

mmcky commented 3 months ago

@albop we work to the version of numba that is distributed with the latest anaconda distribution as our baseline. however if you need numba > 0.59 and it is pinned in your setup.py (or equivalent) then it will get upgraded automatically as our lectures build so that shouldn't be a problem for us.