EconForge / interpolation.py

BSD 2-Clause "Simplified" License
123 stars 35 forks source link

Removed dependencies on pandas and cython. #20

Closed albop closed 6 years ago

albop commented 6 years ago

@cc7768 , @sglyon : there has been some pep-ification behind my back, but what the actual part of this PR:

-    # TODO  do we need a pandas grid here?
-    grid = pd.lib.to_object_array_tuples(points).astype(float)
+    grid = np.array(points)

It seems like a no brainer to me but I also don't understand why you used pandas in the first place. Do you remember it ?

Otherwise we can remove pandas and cython as dependencies.

cc7768 commented 6 years ago

I don't know why we used pandas to do that operation -- Seems silly of us to have done that.

Additionally, it seems like all tests still pass and it simplifies the code/dependencies, so I'm in favor of this change.

albop commented 6 years ago

Thanks. Just wanted to be sure. I'll merge that one then.