EconForge / interpolation.py

BSD 2-Clause "Simplified" License
123 stars 35 forks source link

Conda and pip versions. #60

Closed grburgess closed 4 years ago

grburgess commented 4 years ago

Hi! This package is really great. I am curious if the version on conda and pip are the same. I’m having issues installing both as things seem to be missing.

I would like to fix with a PR, but I’m not used to this poetry System. Is it possible to switch to the standard setup tools?

albop commented 4 years ago

What error do you get? I spent some time last week updating the build system and might have messed up something. As for the standard setup tools, it's not clear there is a standard anymore ;-) Except the pyproject.toml whose content is not actually standardized. I"ll open a separate issue to see how to regenerate another setup.py file, in sync with pyproject.toml.

grburgess commented 4 years ago

with pip, I got an issue with my package installing on travis-ci that the Jupyter checkpoints folder was missing. Not really sure what that means. When installing via conda on travis, eval_linear was not present in the distro.

albop commented 4 years ago

ok, thanks, what a mess. Let me fix that, I'm on it.

grburgess commented 4 years ago

no worries!

albop commented 4 years ago

Just out of curiosity, does it work with the pip version if you do from interpolation.splines import eval_linear ?

grburgess commented 4 years ago

it does, locally I have pip installed. but one of my packages builds on travis with conda.

albop commented 4 years ago

@grburgess : can you check again, please? PyPI and conda packages are freshly released, the latter based on the former so there should be no mismatch. PyPI packages are now based by github on tagged releases. I'll open two other issues for the setup.py and having eval_linear imported in the widest module scope (not sure it's very urgent).

grburgess commented 4 years ago

checking now. Thanks!

grburgess commented 4 years ago

I confirm that it is working now! Thanks a lot. Once I figure out the packaging system, I will have some features in a PR. Cheers.