search

EconForge / interpolation.py

BSD 2-Clause "Simplified" License
123 stars 35 forks source link

Add Hermite cubic splines #90

Closed MalmbergSelma closed 3 years ago

albop commented 3 years ago

Thank you Very much @MalmbergSelma . Would you mind adding a test file ? The file should be located in interpolation.splines.tests, the filename should start with test_... and the test function should start with test_ (cf other examples in the same directory).

albop commented 3 years ago

The PR does not pass all the tests. If you do poetry run pytest, you get an error in file test_hermite_splines

albop commented 3 years ago

Thank you! This looks good. I'll merge it and open some issues to track potential performance problems separately.