[JK] Modified default ad slot size - Githubissues

Econify / ad.js

🚀 Supercharge your Ads.

https://adjs.dev

18 stars 4 forks source link

[JK] Modified default ad slot size #113

Closed kellyjovan closed 4 years ago

kellyjovan commented 4 years ago

Description

if feature:
- Overview of assigned task including architecture and code changes required and acceptance criteria
if bugfix:
- Explanation of the problems behavior & repro steps, the code culprit and the solution.

Bugfix: Use responsive ads with breakpoints adSizes defaults to an empty array which triggers the following warning:

Screen Shot 2019-12-10 at 15 26 34

resolve #112

PR Requirements

Before requesting review this criteria must be met: Overall test coverage >= current master?

[X] Yes
[ ] N.A.

Documentation included (if any behavioral changes)?

[X] Yes
[ ] N.A.

Backwards compatibility (if breaking change)?

[X] Yes
[ ] N.A.

Release

Will this pr trigger a release i.e. version in package.json has been bumped?

[X] Yes
[ ] No

Screenshots

If U.I. component, include screenshots or video screen capture showing behavior and responsive styling below.