search

Ecotrust-Canada / em-control-box

Electronic monitoring control box for commercial fisheries.
GNU General Public License v3.0
2 stars 3 forks source link

Remove hardcoded video resolution settings #31

Open countable opened 8 years ago

countable commented 8 years ago

See commit history where this was changed, and make resolution configurable (in config file). The default should be 640x480 for Digital video, with a framerate of 5fps for both the high and low PSI case.

This change is required before rolling out a Maine release.

marinalan commented 8 years ago

I have question: are those supposed to be only to replace constants to be used for encoderArgs and encoderArgsSlow? if to read from /etc/em.conf video_frame_rate as em_data->SYS_video_framerate - that supposed to replace ANALOG_INPUT_FPS - or ANALOG_OUTPUT_FPS_NORMAL ?

countable commented 8 years ago

We should replace both constant with config entries. There should be another settings SYS_video_framerate_slow which is optional to override only the slow setting. So the user can specify one speed or both.