search

Ecotrust / FishPass

FishPass - Web Frontend Interface for OptiPass
MIT License
2 stars 0 forks source link

Many Barriers are assigned PostPass of 0 for Optipass input #157

Closed rhodges closed 5 years ago

rhodges commented 5 years ago

While working on #149 I see I'm getting the following input file sent to optipass.

BARID,REGION,FOCUS,DSID,USHAB,PREPASS,NPROJ,ACTION,COST,POSTPASS 758651,San Juan Creek,1,759012,0.00875844701932682,0.0,0,0,0,0.0 758652,San Juan Creek,1,758651,0.0043621904373687,0.0,0,0,0,0.0 758653,San Juan Creek,1,758652,0.0242344971514639,0.0,0,0,0,0.0 758654,San Juan Creek,1,758653,0.0345562743683886,0.0,0,0,0,0.0 758656,San Juan Creek,1,758654,0.0172160289144989,0.0,0,0,0,0.0 758657,San Juan Creek,1,758656,0.275503599361259,0.0,0,0,0,0.0 758663,San Juan Creek,1,758657,1.71476599160097,0.0,0,0,0,0.0 758666,San Juan Creek,1,758675,0.398469976825666,0.0,0,0,0,0.0 758669,San Juan Creek,1,758666,3.11159260676829,0.0,0,0,0,0.0 758675,San Juan Creek,1,758676,0.181296164326927,0.0,0,0,0,0.0 758676,San Juan Creek,1,758678,0.0968557375997849,0.0,0,0,0,0.0 758678,San Juan Creek,1,758663,0.0835218787168919,0.0,0,0,0,0.0 758681,San Juan Creek,1,706807,0.778675614762319,0.0,0,0,0,0.0 758682,San Juan Creek,1,758681,0.782494057063785,0.0,0,0,0,0.0 758684,San Juan Creek,1,758682,2.65615909311841,0.0,0,0,0,0.0 758685,San Juan Creek,1,758684,0.205001528452521,0.0,0,0,0,0.0 758686,San Juan Creek,1,758704,0.00311888419325672,0.0,0,0,0,0.0 758704,San Juan Creek,1,758685,0.00817536793276367,0.0,0,0,0,0.0 758705,San Juan Creek,1,758686,0.00802352076798301,0.0,0,0,0,0.0 758706,San Juan Creek,1,758705,0.0801425595968527,0.0,0,0,0,0.0 758713,San Juan Creek,1,758706,0.0510315606006743,0.0,0,0,0,0.0 758715,San Juan Creek,1,758713,0.452031311285054,0.0,0,0,0,0.0 759012,San Juan Creek,1,706788,0.00432132382692525,0.5,0,0,0,0.5 706799,San Juan Creek,1,NA,3.62273335018664,0.5,0,0,0,0.5 706810,San Juan Creek,1,NA,0.493591707904111,0.0,1,0,1,1.0 706788,San Juan Creek,1,716932,13.8475167979629,0.5,0,0,0,0.5 706807,San Juan Creek,1,706809,14.2596630658949,0.0,1,0,1,1.0 706809,San Juan Creek,1,706810,0.0853056117277312,0.5,1,0,1,1.0 716932,San Juan Creek,1,706799,18.5193818312347,0.5,0,0,0,0.5

rhodges commented 5 years ago

Fixed so postpass is not set to prepass if nproj set to 0 - we don't really care about postpass if the barrier cannot be remediated, but it was a bug nonetheless.

rhodges commented 5 years ago

The bigger issue was why all of these were not being considered, which was because I didn't have cost data in my development env for these guys. They were all being left out of consideration.