Ecotrust / ocs-wp

Worpress Implementation of ODFW's Oregon Conservation Strategy
Other
1 stars 0 forks source link

404 and No Search Results Page #70

Closed willthemoor closed 8 years ago

willthemoor commented 8 years ago

For both, remove the default yellow box styling.

If search results:

Copy:

If 404:

Copy: "Sorry, but the page you were trying to view does not exist."

ldford commented 8 years ago

are you assigning this to me for sign-off before implementation? Looks good except for use of "URL". Change to "address" - Double check the address you entered (for the 404 page)

Thanks for the 404/search differentiation. i was conflating. Assign to Drew?

willthemoor commented 8 years ago

Yes on the sign-off (sorry, forgot to mention!). Yes to Drew.

dnseminara commented 8 years ago

@willthemoor - are we supposed to be setting up translations for these two pages or were these just the defaults to begin with? If so, should I be messing with the sage.pot files? If not, can I just use normal html sytanx or should every line of text be enclosed like below?

<?php _e('Sorry, but the page you were trying to view does not exist.', 'sage'); ?>
willthemoor commented 8 years ago

Normal syntax is totally fine.

dnseminara commented 8 years ago

@willthemoor this ticket is mostly complete on ocs.ecotrust.org - however it looks like there are now errors present in relation to the highlight_cpt_parent function in extras.php. Unfortunately, I can't replicate them on my dev version. Figured this has something to do with my configurations vs the staging sites ones?

screen shot 2016-01-06 at 9 55 53 am