Closed willthemoor closed 8 years ago
are you assigning this to me for sign-off before implementation? Looks good except for use of "URL". Change to "address" - Double check the address you entered (for the 404 page)
Thanks for the 404/search differentiation. i was conflating. Assign to Drew?
Yes on the sign-off (sorry, forgot to mention!). Yes to Drew.
@willthemoor - are we supposed to be setting up translations for these two pages or were these just the defaults to begin with? If so, should I be messing with the sage.pot files? If not, can I just use normal html sytanx or should every line of text be enclosed like below?
<?php _e('Sorry, but the page you were trying to view does not exist.', 'sage'); ?>
Normal syntax is totally fine.
@willthemoor this ticket is mostly complete on ocs.ecotrust.org - however it looks like there are now errors present in relation to the highlight_cpt_parent function in extras.php. Unfortunately, I can't replicate them on my dev version. Figured this has something to do with my configurations vs the staging sites ones?
For both, remove the default yellow box styling.
If search results:
Copy:
If 404:
Copy: "Sorry, but the page you were trying to view does not exist."