Ecotrust / usvi

1 stars 4 forks source link

Possible user-unsubmitted record mix up #341

Closed jennywalsh closed 10 years ago

jennywalsh commented 10 years ago

Logged in as Jenny Walsh / jenny.test / jenny@pointnineseven.com

If I go in as Jenny2 Walsh2 and finish those reports and submit them, who will they be submitted as? Is this an issue for fishermen sharing phones? Can there be multiple ID-associated caches of unsubmitted reports on a device?

eknuth commented 10 years ago

Got this. The submitted responses were being left when creating a new user.

Also, the spinner was wonky for zero submitted responses.

eknuth commented 10 years ago

Deployed in 1.2.98

jennywalsh commented 10 years ago

This is still not completely resolved. Unsure if we can. When I log in to the same phone/device as a different user, I see the unsubmitted reports of the previous/other user. This could result in erroneous catch report assignment in the data set.

Do we need to require that each fisher has his own device? If so, that also lets us skip the login step after the first time. If this is the case, let's discuss in greater detail to get the specs right.