Ecwid / consul-api

Java client for Consul HTTP API
Apache License 2.0
416 stars 177 forks source link

Refactor the Node and Service Inner Classes #194

Open jjathman opened 4 years ago

jjathman commented 4 years ago

The QueryNode.Node / HealthService.Node and QueryNode.Service / HealthService.Service inner classes are logically the same thing and should use common classes.

Background

We are looking to convert from using the health service endpoint to the prepared query endpoint but because the Node and Service classes are different classes makes the change more complex than it could have been. Refactoring them to use a shared model would make changes like this much easier.