fix: #186 token as request param is deprecated

Ecwid / consul-api

Java client for Consul HTTP API

Apache License 2.0

416 stars 177 forks source link

fix: #186 token as request param is deprecated #245

Open mehiel opened 1 year ago

mehiel commented 1 year ago

Consul now warns aggressively when token is provided as a request param and the X-Consul-Token is required. Also as already mentioned in #186 token request param will be removed in Consul v1.17.

By reading the code and related PRs I've seen that in the so called "new http architecture" this is addressed although not all clients fully utilize the new Request class.

This PR uses the Request class for both Catalog and KV clients.

Should address both #186 and #237.

mehiel commented 1 year ago

There is also #132 and other token related issues which may need some more effort but it's feasible to get them fixed.

If the maintainers (@vgv ?) are interested I could make another PR and try to address as much clients and API operations as possible.

mehiel commented 8 months ago

Should we declare this project abandoned?

linghengqian commented 8 months ago

Should we declare this project abandoned?

The answer is probably yes. There are currently only two Consul Java Clients that still have active maintainers: https://github.com/kiwiproject/consul-client and https://github.com/vert-x3/vertx-consul-client .