search

Ecwid / consul-api

Java client for Consul HTTP API
Apache License 2.0
416 stars 177 forks source link

AbstractHttpTransport#logRequest always constructs message despite of logging level #248

Open robotmrv opened 3 months ago

robotmrv commented 3 months ago

https://github.com/Ecwid/consul-api/blob/232550b44e122f42446876835946baf2de333f53/src/main/java/com/ecwid/consul/transport/AbstractHttpTransport.java#L133C15-L163C25

Since it logs only at finest level it is reasonable to add short cut check for log level before message construction 

if (!loger.isLoggable(Level.FINEST)) {
    return;
}

to avoid unnecessary memory allocations.