search

Ecwid / ecwid-mailchimp

MailChimp API Wrapper for Java
Apache License 2.0
86 stars 83 forks source link

Added InterestGroup methods #13

Closed donbeave closed 3 years ago

donbeave commented 10 years ago

Support for these methods: 1) http://apidocs.mailchimp.com/api/2.0/lists/interest-group-add.php 2) http://apidocs.mailchimp.com/api/2.0/lists/interest-group-del.php 3) http://apidocs.mailchimp.com/api/2.0/lists/interest-group-update.php

basiliscus commented 10 years ago

Thank you for the contribution. I will review and submit the patch within the next few days.

basiliscus commented 10 years ago

I've reviewed the changes and found the following issues:

  1. The grouping_id field should be of type Integer instead of int. The primitive types are discouraged because it is safer to leave @Field's nullable.
  2. The name specified for InterestGroupDelMethod method is incorrect:

@MailChimpMethod.Method(name = "lists/interest-group-update", version = MailChimpAPIVersion.v2_0)

Perhaps, it should be "lists/interest-group-del"?

donbeave commented 10 years ago

Sorry for that. I just fixed all bugs.