search

Ecwid / ecwid-mailchimp

MailChimp API Wrapper for Java
Apache License 2.0
86 stars 83 forks source link

Create CampaignReport #16

Open er1robyn opened 10 years ago

basiliscus commented 10 years ago

Thank you for the contribution. Unfortunately, there are some issues which prevent me from submitting the patch:

  1. The result type (Boolean) does not match the structure described at http://apidocs.mailchimp.com/api/rtfm/campaignstats.func.php . A new class (inherited from MailChimpObject) should be created to reflect the method return.
  2. To follow the naming convention, the class name should be CampaignStatsMethod instead of CampaignReport.

I'll gladly submit the patch once the issues are eliminated and the method outcome is tested.

er1robyn commented 10 years ago

No Issues Sir basiliscus,I made the return method and after testing I will again send you the Pull request. Thanks for your reply.