search

Ecwid / ecwid-mailchimp

MailChimp API Wrapper for Java
Apache License 2.0
86 stars 83 forks source link

Some more campaign and segment related methods #4

Closed mlusetti closed 11 years ago

mlusetti commented 11 years ago

I know tests are missing but no functionality has been changed just methods (api) added and the only valuable tests are integrations tests. If you really need I can add it, anyway I'll add them as soon as I have spare cycle available.

Cheers

basiliscus commented 11 years ago

Thanks Massimo, your work is much appreciated! I'll review and merge your changes as soon as I have a minute (perhaps on the weekend).

basiliscus commented 11 years ago

I've had a very rought view at your code, nice job. The only concern I have by now is the 'type' field in CampaignCreateMethod.

Shouldn't we use an enum type instead of String here? I believe enums are easier to operate than strings. Yes, there is a risk that a new constant will be added in a new version of API, but we can update the wrapper correspondingly. What do you think?

mlusetti commented 11 years ago

Sure, probably it's has been a leftover. No objections.

BTW If you merge this would you mind to release is as 1.3.0.4 soon after?

basiliscus commented 11 years ago

Sure, I will release a new version.

basiliscus commented 11 years ago

I've merged the changes and released a new version (1.3.0.4). It will appear in Maven Central in few hours. Thanks for your contribution.