search

EdJoPaTo / website-stalker

Track changes on websites via git
GNU Lesser General Public License v2.1
54 stars 6 forks source link

feat: css_sort #190

Closed EdJoPaTo closed 3 months ago

EdJoPaTo commented 10 months ago

closes #189

github-actions[bot] commented 8 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

EdJoPaTo commented 8 months ago

Ah, well… stale… as stated in https://github.com/EdJoPaTo/website-stalker/issues/189#issuecomment-1862418307 I don't like the current implementation and I don't really know how to usefully deal with it.

EdJoPaTo commented 6 months ago

I don't think the current approach is useful and has its problems (as described in the linked issue). I'll close this for now as no other ideas came up yet.

Teufelchen1 commented 6 months ago

You could convert it to a draft instead. Making it easier to search for.

EdJoPaTo commented 3 months ago

Played around with this and the just merged debug_files editor and this is really neat together to understand what happens.

EdJoPaTo commented 3 months ago

@Hans-Maulwurf With the current state of this feature I'm quite happy. Does the description of it in the README sound helpful to you or do you have any improvement suggestions?

Teufelchen1 commented 3 months ago

Nice! :tada:

@EdJoPaTo could you give me feedback on my review(-style)? Was it helpful? Did you perceive me as aggressive or as friendly? Are there certain aspects I should focus more or less on? Personally I am satisfied as I do have the feeling of positively impacting the merged code quality while simultaneously have learned new things.