EdJoPaTo / wikidata-entity-reader

read information of wikidata entities in a simpler way
MIT License
0 stars 0 forks source link

Nice idea #20

Open mshd opened 2 years ago

mshd commented 2 years ago

Hi,

check out https://www.npmjs.com/package/@entitree/helper maybe we can collaborate!

Cheers, Martin

EdJoPaTo commented 2 years ago

It looks interesting! I have to give it a look when I work with this library the next time and see if it can be refactored easily. Maybe it "just works" or create issues for whats missing.

Looks like it tries to achieve both this library and wikidata-sdk-got. Without looking much into it I expect it to be a problem when trying to work with Deno as Deno assumes the fetch API. For Deno only this reader library can be used while the wikidata-sdk-got part is replaced by code made for the fetch API. (But maybe axiom works nicely in Deno? Havnt looked into it.)

Also Wikibase has a bunch of typings which are implemented in wikibase-types. It might be useful to use that library in your library to have the typings alone in their dedicated place as they work independently.

When I have time to work on stuff which currently uses this library I will try your library and will be able to give more thoughts about it!