search

EdddieN / machinon-domoticz_theme

GNU General Public License v3.0
46 stars 21 forks source link

[Firefox] theme.logo is null #259

Closed DarkAllMan closed 5 years ago

DarkAllMan commented 5 years ago

Logo not showing :) Console says: theme.logo is null

DewGew commented 5 years ago

clear localstorage

DarkAllMan commented 5 years ago

I already did that. Just did it again to confirm... but it did not solve the issue. When I tried another browser (chrome) it shows the logo... so it must be a browser issue.... need tot check what is going on there.

davidlb commented 5 years ago

What's your browser?

DarkAllMan commented 5 years ago

Firefox

Op wo 15 mei 2019 17:50 schreef David Le Brun notifications@github.com:

What's your browser?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/EdddieN/machinon-domoticz_theme/issues/259?email_source=notifications&email_token=AAMCKB7HPRVTCZLFVLPNFTLPVQWMNA5CNFSM4HNCKDU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVPDFAQ#issuecomment-492712578, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMCKBZ7ZI7GDZDEEIHREKTPVQWMNANCNFSM4HNCKDUQ .

davidlb commented 5 years ago

I cannot reproduce it on Firefox 66.0.5 (Win64) but I had to remove local storage --> Press F12 to open the Developer tools and in the Storage tab, click Local Storage. RIght click on the entry and select Delete All.

DarkAllMan commented 5 years ago

I played around last night.. I ticked notification bar on and of… then it appeared again….

From: David Le Brun notifications@github.com Sent: donderdag 16 mei 2019 09:51 To: EdddieN/machinon-domoticz_theme machinon-domoticz_theme@noreply.github.com Cc: DarkAllMan randall.kam@gmail.com; Author author@noreply.github.com Subject: Re: [EdddieN/machinon-domoticz_theme] theme.logo is null (#259)

I cannot reproduce it on Firefox 66.0.5 (Win64) but I had to remove local storage --> Press F12 to open the Developer tools and in the Storage tab, click Local Storage. RIght click on the entry and select Delete All.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/EdddieN/machinon-domoticz_theme/issues/259?email_source=notifications&email_token=AAMCKBZHQQLEKAOVUW2WC4DPVUG73A5CNFSM4HNCKDU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQ7KLQ#issuecomment-492959022 , or mute the thread https://github.com/notifications/unsubscribe-auth/AAMCKB6DF4VTPUF3PAK6SR3PVUG73ANCNFSM4HNCKDUQ . https://github.com/notifications/beacon/AAMCKB2WOCQUYX5PEWVORDTPVUG73A5CNFSM4HNCKDU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVQ7KLQ.gif

davidlb commented 5 years ago

I finally manage to reproduce this bug, I'll work on it this week.

davidlb commented 5 years ago

In fact, it was due to bad uservariables in Domoticz probably due to a previous buggy version of the theme. Delete all theme-machinon* user variables in Domoticz (Setup / User Variables). Clear storage in your local browser and it should be ok now.

DarkAllMan commented 5 years ago

This seems to have solved the issue :)

DarkAllMan commented 5 years ago

Sorry, after a refresh of the page, the logo disappeard again!

davidlb commented 5 years ago

I fixed few issues related to Firefox this morning, can you update to the latest beta branch and retry? Can you send a screenshot/copy paste of Domoticz user variables?

DarkAllMan commented 5 years ago

Can you explain which console commands I need to give to change to the beta branche? Or do you suggest to create a second theme for the beta?

davidlb commented 5 years ago

If you did a git clone to get the theme, just go to the theme folder and type: git checkout beta git pull

DarkAllMan commented 5 years ago

Branch 'beta' set up to track remote branch 'beta' from 'origin'. Switched to a new branch 'beta' git pull: Already up to date.

davidlb commented 5 years ago

Good, so you're already on the beta branch. I've just found another bug on Firefox regarding the Reset Button, I'll ping you when I'm done.

DarkAllMan commented 5 years ago

First tests show the problem solved now, even after refreshing the pages. User Variables show: theme-machinon-custom (string): ["","","","",null,"",null] theme-machinon-features (string): [15,29,33]

I'm done for today.... will check back tomorrow.

davidlb commented 5 years ago

Ok, thanks for your help! I keep you informed.

davidlb commented 5 years ago

Can you give it a try?

DarkAllMan commented 5 years ago

All seems to be ok.

davidlb commented 5 years ago

Oops wrong issue reopened, I close it