Theme is calling 'checkauth()' every time

EdddieN / machinon-domoticz_theme

GNU General Public License v3.0

46 stars 21 forks source link

Theme is calling 'checkauth()' every time #284

Closed davidlb closed 5 years ago

davidlb commented 5 years ago

This is not needed, it seems to make the temperature widgets scrolling info to hickup as well... The 'admin rights' is already in the rootScope which you can already access

Reported by gizmocuz in domoticz/domoticz#3302

DewGew commented 5 years ago

This is because we want to get adminrights when hide/show buttons in navigation if user is admin or not. https://github.com/EdddieN/machinon-domoticz_theme/blob/b42e9c9c30d814c6de8b3790bb217db538691fd8/custom.js#L130 https://github.com/EdddieN/machinon-domoticz_theme/blob/b42e9c9c30d814c6de8b3790bb217db538691fd8/custom.js#L178 https://github.com/EdddieN/machinon-domoticz_theme/blob/b42e9c9c30d814c6de8b3790bb217db538691fd8/js/settings_page.js#L23

maybe there is a simplier way.

chrislader commented 5 years ago

@davidlb I'm totally on this topic as well.

Since I have about 40 temperature sensors, opening the Temperature tab is really a problem.

When I open the tab;

All temp sensors show the scrollable part (with empty values, very slow)
Then one by one they disappear (when updates are received from the temp sensors)
It takes about 10 minutes for the screen to be normal

Personally I would get rid of the scrollable part on ALL sensors and just add it where it makes sense (so the other way arround).

If we keep the scrollable part then I am forced to remove the part manually after every update/install as I do now.

about 10 mins later:

davidlb commented 5 years ago

Guys, can you update to latest beta? I rewrote checkauth without ajax call, removed getstatus calls and removed autoscroll for global performance improvement. Well, it seems but I need your feedback :)

chrislader commented 5 years ago

@davidlb just updated to latest beta domoticz (915) + latest beta machinon theme.

A LOT better now. For me this is fixed. Page loads quite fast now.

Want me to check some specific logs?

davidlb commented 5 years ago

@chrislader thansk for your feedback!