search

EddieDover / fvtt-party-sheet

A module for FoundryVTT providing a system-agnostic JSON-templated party sheet.
MIT License
4 stars 4 forks source link

feat(schema): added schema for templates #35

Closed LeCuay closed 3 months ago

LeCuay commented 3 months ago

Summary

Since this project relies on people editing JSON directly I thought it'd be a good idea to have an schema for it.

I added it to the .vscode folder and tweaked the settings. Not sure if this is the way but since it was there already it felt natural.

The conditionals work by automatically detecting type and then looking for required keys.

It's not intended for this schema to replace documentation. It just to force checks when typing and improve intellisense.

LeCuay commented 3 months ago

Just realized it's missing else optional property for match but what do you think so far?

EddieDover commented 3 months ago

Just realized it's missing else optional property for match but what do you think so far?

Love it so far. I've been working on a visual creator but as you can imagine it's quite the chore and finding time to peck away at it between other responsibilities is rough. This PR goes a long way to helping people make sane templates until it's finished.

EddieDover commented 3 months ago

Any issues holding off on this until we get the others PRs finalized? That way you can add the rowspan and other updates?

LeCuay commented 3 months ago

Any issues holding off on this until we get the others PRs finalized? That way you can add the rowspan and other updates?

No problem at all! Waiting so we have all implemented sounds good

LeCuay commented 3 months ago

Added else statement

LeCuay commented 3 months ago

Added all new properties as per #39 and #30.

LeCuay commented 3 months ago

Knock out the colspan reference and this is good to go.

Donezo