EddieHubCommunity / BioDrop

Connect to your audience with a single link. Showcase the content you create and your projects in one place. Make it easier for people to find, follow and subscribe.
https://biodrop.io
MIT License
5.73k stars 3.97k forks source link

[BUG] Duplicate sortable package present #10139

Open ChinmayMhatre opened 8 months ago

ChinmayMhatre commented 8 months ago

Has this bug been raised before?

Where did you find this bug?

Production

Version of BioDrop (for example "v1.2.3")

2.99.3

Description

I noticed two sortablejs and react-sortable packages. https://github.com/EddieHubCommunity/BioDrop/blob/main/package.json (Line 41 and 48 )

I searched for usage in the project But only found one being used in the project.

image

https://github.com/search?q=repo%3AEddieHubCommunity/BioDrop%20%22sortablejs%22&type=code

P.S. One could depend on the other but wanted to raise a request just in case.

Steps to Reproduce

Screenshots

No response

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

github-actions[bot] commented 8 months ago

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/BioDrop/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

eddiejaoude commented 8 months ago

Oh good spot, it looks like the sortablejs got added recently. I think it could be tested without this package and see if sorting works

github-actions[bot] commented 8 months ago

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

salisshuaibu11 commented 8 months ago

i would like to take this one

ChinmayMhatre commented 8 months ago

@salisshuaibu11 assigned it to you

SaraJaoude commented 7 months ago

As it has been two weeks since this was assigned to you @salisshuaibu11 and as no PR has been created, I am unassigning this issue so that we can give someone else the opportunity to work on it.

dreamycodex commented 7 months ago

Hi. Could I work on this please? Thank you.

ChinmayMhatre commented 7 months ago

@dreamycodex Assigned you the issue

ℹ️ ChinmayMhatre has some opened assigned issues: 🔧View assigned issues

harshwasthere commented 6 months ago

Hi, can I work on this issue? it is still assigned to someone but it's been a month and it is still unresolved.

eugene4545 commented 5 months ago

hello, can i be assigned to this issue?

eddiejaoude commented 5 months ago

@Harsh12Codes I couldn't see a PR either, so yes we can reassign it to you as 2 weeks has past since being assigned

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues

harshwasthere commented 4 months ago

@eddiejaoude I found out that react-sortable.js is dependent on sortable.js, so there is no duplicate to remove.

image

irungudennisnganga commented 4 months ago

hello, can i be assigned to this issue?

vinitmehta51 commented 4 months ago

@ChinmayMhatre:- Is this issue still needs to be kept open, as @Harsh12Codes confirms that both the packages are needed. As one of the package is dependent on the other package.